Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better crash diagnostics #232

Open
j-mie6 opened this issue Apr 5, 2024 · 0 comments · Fixed by #234
Open

Better crash diagnostics #232

j-mie6 opened this issue Apr 5, 2024 · 0 comments · Fixed by #234
Labels
enhancement New feature or request

Comments

@j-mie6
Copy link
Owner

j-mie6 commented Apr 5, 2024

Occasionally, parsley can throw an error from within an instruction execution. There are three main sources for this to occur within:

  • An error within a user-defined function called from inside a parser
  • An out of scope reference being polled after unsafe initialisation
  • A legitimate bug in parsley

It would be good to try and distinguish between these, where possible, and catch any exceptions generated within the parser. These can be rethrown from outside the parsing context, removing any noise for user-made errors, report likely causes from undefined behaviour within parsley, and otherwise provide a more useful and detailed diagnostic for me that can be used in a bug report.

@j-mie6 j-mie6 added the enhancement New feature or request label Apr 5, 2024
@j-mie6 j-mie6 linked a pull request Apr 9, 2024 that will close this issue
j-mie6 added a commit that referenced this issue Apr 9, 2024
Closes #232 by catching common errors and presenting them to the user in
a more accessible way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant