Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PASS violates RFC and doesn't work #24

Open
Cheaterman opened this issue Nov 28, 2020 · 2 comments
Open

PASS violates RFC and doesn't work #24

Cheaterman opened this issue Nov 28, 2020 · 2 comments

Comments

@Cheaterman
Copy link

https://github.com/j0ack/discirc/blob/master/discirc/irc_bot.py#L75

This violates the RFC and therefore doesn't work.

A "PASS" command is not required for either client or server
connection to be registered, but it must precede the server message
or the latter of the NICK/USER combination

Reordering these lines properly does work. :-)

@j0ack
Copy link
Owner

j0ack commented Jan 4, 2021

I remember encounter some errors for servers needing PASS but I can't remember which.
Can you submit a PR resolving this issue ?

@TeoTwawki
Copy link
Contributor

TeoTwawki commented Jan 5, 2021

I remember encounter some errors for servers needing PASS but I can't remember which.

Rizon network iirc back then. Dunno if its still the case. I knew they violated spec but it didn't seem to bother freenode to do things "wrong" (in order for rizon to work) back then.

My team has since stopped using irc and since my bouncer got kicked, I no longer had an interest in keeping a bridge going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants