Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/documentation: bracketed property access is not rewritten #37

Open
domenic opened this issue Aug 13, 2019 · 0 comments
Open

Test/documentation: bracketed property access is not rewritten #37

domenic opened this issue Aug 13, 2019 · 0 comments
Milestone

Comments

@domenic
Copy link
Collaborator

domenic commented Aug 13, 2019

We currently do not rewrite things like

Math['max']();
Math['m' + 'ax']();

This is fine. (And perhaps even desired; if you specifically want to escape the rewriter, it provides an escape hatch.)

We should add tests showing that this does not happen, and then document this "limitation" in the readme, including referencing an ESLint rule you can use to avoid such property accesses in your project if you want to be sure the rewriter catches them all.

@domenic domenic added this to the Polish milestone Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant