Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required parameter $cdnDomain follows optional parameter $isCname #91

Open
kalokcheung opened this issue Jan 4, 2022 · 2 comments
Open

Required parameter $cdnDomain follows optional parameter $isCname #91

kalokcheung opened this issue Jan 4, 2022 · 2 comments

Comments

@kalokcheung
Copy link

使用php 8.0會出現：Required parameter $cdnDomain follows optional parameter $isCname
問題在 jacobcyl/ali-oss-storage/src/AliOssAdapter.php 的 __construct function 的 signature
不是required的 $isCname 放於required的 $cdnDomain 前
@ethanfly
Copy link

https://github.com/ethanfly/Aliyun-oss-storage

@ethanfly
Copy link

我fork了一个，修改了一下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ethanfly @kalokcheung