Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid snapshot in operationDetailsTable/index.test.js #2659

Open
yurishkuro opened this issue Feb 11, 2025 · 0 comments
Open

Avoid snapshot in operationDetailsTable/index.test.js #2659

yurishkuro opened this issue Feb 11, 2025 · 0 comments
Labels
good first issue help wanted

Comments

@yurishkuro
Copy link
Member

packages/jaeger-ui/src/components/Monitor/ServicesView/operationDetailsTable/index.test.js

The automated upgrade of AntD in #2658 failed because the snapshot needed to be regenerated, for meaningless changes like this:

-  className="ant-col ant-col-24 css-dev-only-do-not-override-cdzvx5"
+  className="ant-col ant-col-24 css-dev-only-do-not-override-1yacf91"

Our tests should not be depending on implementation details of the 3rd party library. The goal is to rewrite this test using react testing library practices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yurishkuro