Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to use every-ts bisect run to look for a commit that *fixed* an issue #51

Open
danvk opened this issue Feb 28, 2024 · 1 comment

Comments

@danvk
Copy link

danvk commented Feb 28, 2024

The docs explain how to use every-ts bisect run to find the commit that broke something, but sometimes you want to find the commit that fixed an issue.

Case in point: I tried to repro #33191 at HEAD today and couldn't. It was fixed sometime after 5.3.2.

I wound up doing it with this script that flips the exit codes. But maybe there's a better way that doesn't require that.

#!/bin/bash

if every-ts tsc -p tsconfig.json ; then
  echo 'good'
  exit 1
else
  echo 'bad'
  exit 0
fi
@jakebailey
Copy link
Owner

I was aiming not to do write too much on this, under the assumption that I would effectively just repeating the git bisect docs linked in the README.

I wound up doing it with this script that flips the exit codes. But maybe there's a better way that doesn't require that.

My example in the README actually uses the terms old and new for that reason. Though, I see now that I accidentally flipped the example, so I'll fix that quick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants