Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rubocop binstub #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clayallsopp
Copy link

For performance reasons, this adds a preference for the bin/rubocop that might be installed on some projects to the default bundle exec behavior

@jakeonrails
Copy link
Owner

Sorry for taking so long to respond. I checked out your branch and when I went to run it on Ruby 2.4.1 it failed badly. Not your fault - not a problem with your code, but rather, older versions of some of this project's dependencies don't run well on 2.4.1 due to some new Fixnum compatibility issues.

Rest assured I'm going to merge this in, and possibly bump some versions of dependencies.

Thanks again for your contribution, I appreciate the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants