Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intent check bypassed due to init setting #215

Open
wants to merge 1 commit into
base: v2.0.0-rc1
Choose a base branch
from

Conversation

inDream
Copy link

@inDream inDream commented Jun 28, 2014

Currently hasIntent part of dragging would never entered as hasIntent is undefined.

@ronmichael
Copy link

I ran into this too. Although I went with a different solution: around like 511 I replaced

       if (cache.hasIntent === false || cache.hasIntent === null) 

with

       if (!cache.intentChecked)

@inDream
Copy link
Author

inDream commented Oct 27, 2014

Both solution work, but I think it's better to set an init value for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants