(feat) Add support for generating modules #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Patel-world
changed the title
Patel-world
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
plopfile.mjs
Outdated
| { | ||
| type: "input", | ||
| name: "name", | ||
| message: "Name your resource: ", |
There was a problem hiding this comment.
How about we use module instead of resource?
| app.use(bodyParser.urlencoded({ extended: true })); | ||
| app.use(bodyParser.json()); | ||
|
|
||
| app.use('/organization account', OrganizationAccountRouter.getRoutes()); |
There was a problem hiding this comment.
can this be asked as a question too - like what rest base url you want for the module? If user presses Enter you can fall back to default one.
Also we are missing a hyphen
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: jalantechnologies_boilerplate-mern |
|
Deployment (boilerplate-mern) is available at - https://4a492aace6a73cd.preview.platform.jalantechnologies.com |
Minimum allowed line rate is |
devanuj97
approved these changes
Oct 19, 2023
|
This PR is being closed due to inactivity. Our team has logged the issue and this will get taken care of in future releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
generates module on running
npm run plopDatabase schema changes
NA
Tests
Automated test cases added
Manually tested
Kindly review
organization-accountgenerated using plop and template