Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of assessment #1

Open
jamesbright opened this issue Jan 12, 2021 · 3 comments
Open

Review of assessment #1

jamesbright opened this issue Jan 12, 2021 · 3 comments
Assignees

Comments

@jamesbright
Copy link
Owner

jamesbright commented Jan 12, 2021

Please @dreplica @markeu I would like you to review my work. I'm done with the features outlined including deployment https://dashboard-3470d7.netlify.app/. if there's any other thing I need to do, I would appreciate it if you can point that out. thanks.
James Ononiwu.
[email protected]

@dreplica
Copy link
Collaborator

I couldn't access your application, it had an app loader that wont stop.

  • Your code looks okay but lots of repetition and no optimisation.
  • Most frameworks and library help with browser compatibility, your css had lots of compatibility check which was an overhead.

@jamesbright
Copy link
Owner Author

jamesbright commented Jan 21, 2021 via email

@jamesbright
Copy link
Owner Author

I couldn't access your application, it had an app loader that wont stop.

  • Your code looks okay but lots of repetition and no optimisation.
  • Most frameworks and library help with browser compatibility, your css had lots of compatibility check which was an overhead.

Please recheck, you can access it now https://dashboard-3470d7.netlify.app/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants