Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications needs a re-write #46

Open
jameslkingsley opened this issue Jun 3, 2017 · 0 comments
Open

Notifications needs a re-write #46

jameslkingsley opened this issue Jun 3, 2017 · 0 comments

Comments

@jameslkingsley
Copy link
Owner

jameslkingsley commented Jun 3, 2017

Currently notifications are storing model data and then computing on-the-go which means the state of the given model could have changed, thus throwing errors.

Rather than attempt to catch every error, it would be better to simply store static data containing the text, avatar and link and simply let the application handle any 404's etc.

Also need a 'mark all as read' button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant