Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObservableObject.PropertyChanged event is not weak #71

Open
curia-damiano opened this issue Aug 18, 2020 · 1 comment
Open

ObservableObject.PropertyChanged event is not weak #71

curia-damiano opened this issue Aug 18, 2020 · 1 comment

Comments

@curia-damiano
Copy link

Hi,
I see that the implementation of ObservableObject uses the PropertyChanged event, but it is not through the WeakEventManager (see line 47 of ObservableObject.cs).
If this event is not unhooked, it could create memory leaks in applications.
So I would suggest to replace it like in Commands/Command.cs, line 114.
Would you appreciate if I would submit a PR?
Regards, Damiano
@jamesmontemagno
Copy link
Owner

Sure thing

@curia-damiano curia-damiano mentioned this issue Aug 24, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesmontemagno @curia-damiano