Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RollupFlowFullRecalcDispatcher invocable doesn't recalculate all rollups #629

Open
baobao917 opened this issue Sep 27, 2024 · 8 comments · Fixed by #632
Open

RollupFlowFullRecalcDispatcher invocable doesn't recalculate all rollups #629

baobao917 opened this issue Sep 27, 2024 · 8 comments · Fixed by #632

Comments

@baobao917
Copy link

baobao917 commented Sep 27, 2024

@jamessimone I had an issue with using the Full Recalc CMDT driven invocable. I passed a comma separated list of 9 rollups (using the API names) and it's only doing full recalcs on 3 of them. (It's not even the first 3 or last 3 in the list but just smack dab in the middle of the list). Not sure if this is user error on my part or if it's a bug. Also not sure if I should have spawned this off into a separate issue ticket.

Here is a video recording of the issue https://www.loom.com/share/50814e63ab5d4820870076ae0fe70998

Pls let me know if you need anything else.

@jamessimone I am going to open a separate issue for this issue with the Full Recalc CMDT driven invocable to separately track it from this original issue.

Originally posted by @baobao917 in #624 (comment)

@jamessimone
Copy link
Owner

@baobao917 I found the issue with this, it's specific to using text templates for the comma-separated list. I will fix this today!

@baobao917
Copy link
Author

@jamessimone That's great to hear, however, I'm not sure that was the only reason. I also put the comma-separated list directly into the resource field instead of using a text template....it still didn't work.

@jamessimone
Copy link
Owner

Do you have an example of that? As far as I can tell the only rollups that won't run when properly formatted would be ones with no matching children. Is it possible that you copied and pasted from the text template to the action? There could have been hidden formatting characters if so, which is what I'm fixing now

@baobao917
Copy link
Author

baobao917 commented Oct 2, 2024 via email

jamessimone added a commit that referenced this issue Oct 2, 2024
…) for the Full Recalc CMDT-driven Invocable rollup action
@jamessimone
Copy link
Owner

Happy to take a look, and to re-open this issue if necessary. I'll have limited development time over the next two weeks, so it may be a bit before I'm able to fully address any remaining issues with this invocable. Certainly the issue that you demonstrated has just been fixed in the latest release. There should now be no difference between using your flow and kicking off a full recalc with the CMDT records selected using the full recalc app

@baobao917
Copy link
Author

baobao917 commented Oct 3, 2024

@jamessimone The latest release v.1.6.35 does not appear to have fixed the issue. Please see video below for a demo. I tried to re-open this issue but could not. Totally understandable on time constraints. Just happy that you will be looking into it. Appreciate you!

https://www.loom.com/share/e4cba46e4b4345669fe79c0326dc7973

@baobao917
Copy link
Author

o, which is what I'm fixing now

Also just saw this comment. It doesn't explain why all 5 of the rollups didn't fire. But 4 of the 5 were ones where the Account didn't have any child Payable records...but in that case, I would have expected it to recalculate the rollup fields as 0 (which is what it does when I do a full recalc using the app or using the Recalculate Rollups button). 1 of the 5 that didn't recalculate, there was child records so the above doesn't explain why it didn't recalculate.

@jamessimone jamessimone reopened this Oct 3, 2024
@baobao917
Copy link
Author

Hi @jamessimone - Hope all is well. Have you had a chance with this yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants