Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a User-Agent for API requests #36

Open
jfretheim opened this issue Oct 1, 2024 · 0 comments
Open

Set a User-Agent for API requests #36

jfretheim opened this issue Oct 1, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jfretheim
Copy link
Contributor

jfretheim commented Oct 1, 2024

Currently, the User-Agent sent to Jamf Pro is Microsoft.Data.Mashup (https://go.microsoft.com/fwlink/?LinkID=304225). For better monitoring and metrics, let's set a specific value that includes the version (something like Jamf Pro Power BI Connector/2.0.0).

A good set of guidelines for User-Agent values can be found here: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent


Considerations/nice-to-haves for the "comment" section of a User-Agent string:

  • build metadata and/or branch name for non-release builds
  • information about whether request is coming from Power BI Desktop or powerbi.com (if possible)
  • the table being populated for the API call
    • down the road, if a cleaner/modern data model is added to this connector, we may want this additional metric to help us decide when it is safe to deprecate or remove the code that supports the old tables (this is a pretty long-term consideration, but worth thinking about as part of this issue)
@jfretheim jfretheim added the enhancement New feature or request label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant