Allow server list sorting

[sxiii]

Asc/desc sort function into server list by number of users / location / ping / server name

I would like to choose server based on different criteria.

[ann0see]

Maybe this is already possible with the filter option next to the list selection?

[dcorson-ticino-com]

For the moment the server list is only sorted by ping time.
The filter function reduces the list to servers where the filter string is found in one of the fields.
Personally I have never felt the need to sort by anything other than by ping, the filter works well for special occasions, but it would certainly be possible if we decide that is desirable.

[gilgongo]

Congratulations @sxiii ! You are the first person to use our new Issue reporting template.

Since this is I think a pretty clear request (and sorting is in fact implemented when --showallservers is on I think), I propose we keep it here. If anyone wants to pull it into a protracted discussion (eg if this feature would break something) they can do, at which point we can move it out to Discussions if needed.

[dcorson-ticino-com]

I correct myself.
Because of a apparent code error, the code doesn't do what the commentary says, you can sort on all but the server name when you use the --showallservers command line option.
The disadvantage is that you see all the servers the central server knows about, even those that do not respond to the pings of your computer.
A registration number is also prepended to the server name which is why the sort on server name does not work.

[gilgongo]

OK so this isn't as straightforward as making sorting available in the non-showallservers condition then. And there may be other thing. Moving to a discussion.

[dingodoppelt]

Asc/desc sort function into server list by number of users / location / ping / server name
I would like to choose server based on different criteria.

https://github.com/dingodoppelt/jamulus/tree/sortableserverlist

Hi, I fixed it in my fork. Give it a try :)

[gilgongo]

Having it default to sorted by ping times is best though I think, because most of the time that's what you're interested in for jamming at least. BTW is the "pause on mouse over" disabled in this build? Seem so.

[dingodoppelt]

BTW is the "pause on mouse over" disabled in this build? Seem so.

yes, because it really bugged me the most. i changed it to sort by musicians per default because i found myself clicking the "musicians" for sorting anyway. and it works around the list jumping. if you want to join a server do it the old fashioned way: click a server once, then hit "enter" to join that server. no need for doubleclick :)

[gilgongo]

Ah OK, and yes that mouseover feature was a bit odd. I didn't spot that it's sorted by musicians :-) A default sort of ping time sub-sorted by musicians would be pretty good if that was possible.

[dcorson-ticino-com]

I don't think this is a good idea for general release. The ping time is too important to not have it as the major sorting factor.
It would be good if we could have an optional two column sort, like musicians and ping. Unfortunately I do not see this capability in Qt at the moment, we would have to develop it.
I understand why the mouseover was introduced, but it is something of a hack in use. We do need to retain at least the use of the minimum ping time to reduce the list jumping. This is not in the --showallservers code.
In general, this will be much more work than just making the --showallservers case the default.

[gilgongo]

@dcorson-ticino-com Nobody's suggesting --showallservers should be the default, are they? We're just talking about making columns sort as is the case in --showallservers.