Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent values of bg_1 and bg_2 in the-values.md #99

Open
zeta709 opened this issue Jan 31, 2022 · 1 comment · May be fixed by #100
Open

Inconsistent values of bg_1 and bg_2 in the-values.md #99

zeta709 opened this issue Jan 31, 2022 · 1 comment · May be fixed by #100

Comments

@zeta709
Copy link

zeta709 commented Jan 31, 2022 •
edited
Loading

The values of bg_1 and bg_2 seem incorrect in the-values.md.
For example, comparing the values in the-values.md and urxvt/selenized-dark.xdefaults, you can see differences like:

Dark:
bg_1: #184956 vs. #174956
bg_2: #2d5b69 vs. #325b66

Light:
bg_1: #ece3cc vs. #e9e4d0
bg_2: #d5cdb6 vs. #cfcebe

After having a look at the git history, I found that the document shows an older version of color set. Commit c5d9447 seems to be related.
zeta709 added a commit to zeta709/selenized that referenced this issue Feb 1, 2022
@zeta709
Doc: update the-values.md
5d42d5e 
As a result of commit c5d9447, the
color values changed. Update the document accordingly.

Issue: jan-warchol/issues/99
zeta709 added a commit to zeta709/selenized that referenced this issue Feb 1, 2022
@zeta709
Doc: update the-values.md
9efeaac 
As a result of commit c5d9447, the
color values changed. Update the document accordingly.

This closes jan-warchol/issues/99
@zeta709 zeta709 linked a pull request Feb 1, 2022 that will close this issue
Open
@stablestud
Copy link

@zeta709 thanks for pointing this out. So every theme that's based on the-values.md is then slightly incorrect?
That would be quite unfortunate.

I think this is currently the most important issues/PR that should be fixed/merged.

@jan-warchol could you please take a look?

stablestud added a commit to stablestud/dotfiles that referenced this issue Aug 17, 2024
@stablestud
Revert Selenized colors to match reference values
fe1eecf 
The Selenized reference document the-value.md contains incorrect
values for the `bg_1` and `bg_2` colors in the light and dark variants.
Although the previous commit corrected these values,
this commit reverts them to match the incorrect reference values.

This ensures consistency, as the incorrect reference is still used widely.
Here we continue using these values until the reference is officially
updated.

For more details, see: jan-warchol/selenized#99
stablestud added a commit to stablestud/dotfiles that referenced this issue Aug 17, 2024
@stablestud
Revert Selenized colors to match reference values
56ac373 
The Selenized reference `the-value.md` contains incorrect
values for the `bg_1` and `bg_2` colors in the light and dark variants.
Although the previous commit corrected these values,
this commit reverts them to match the incorrect reference values.

This ensures consistency, as the incorrect reference is still used widely.
Until the reference is officially updated, we'll be using the incorrect
values.

For more details, see: jan-warchol/selenized#99
mgaffney added a commit to mgaffney/selenized.nvim that referenced this issue Dec 28, 2024
@mgaffney
Revert dark theme values for bg_1 and bg_2
c3da6e8 
As of this commit, the values in the selenized git repository for the
bg_1 and bg_2 colors are incorrect. An issue describing the problem,
along with a pull request to fix it, were opened on 2022-01-31 but
remain open as of this commit (see
jan-warchol/selenized#99 and
jan-warchol/selenized#100).

The upstream repository this repository is forked from contained the
corrected values for bg_1 and bg_2. However, commit 5940ba4 (Fix cursor
and tab colors, 2024-11-01) reverted the values for bg_1 and bg_2 in the
dark theme back to original broken values. This commit reverts those
changes.
@mgaffney mgaffney mentioned this issue Dec 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Doc: update the-values.md zeta709/selenized
2 participants
@zeta709 @stablestud