You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now, if any other project needs this dependency, they can't just take this maintained version, they have to roll their own, and there will be no collaboration possible.
Please do a fork as is custom (and as the previousmaintainer requested), package it and add it as a dependency to this project.
~ Sincerely, someone who very recently spent a very large amount of time removing ancient integrated libraries from a project I took over, and I am not even done with it yet.
This 884f766 commit takes https://github.com/JordanMilne/Advocate and instead of forking and putting it in requirements.txt, it hardcodes it into the code base.
Now, if any other project needs this dependency, they can't just take this maintained version, they have to roll their own, and there will be no collaboration possible.
Please do a fork as is custom (and as the previousmaintainer requested), package it and add it as a dependency to this project.
~ Sincerely, someone who very recently spent a very large amount of time removing ancient integrated libraries from a project I took over, and I am not even done with it yet.
EDIT: I see this is not the only bundled library - https://github.com/janeczku/calibre-web/tree/master/cps/cw_login
The text was updated successfully, but these errors were encountered: