Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please do not hardcode copy other Python libraries #3181

Open
C0rn3j opened this issue Oct 9, 2024 · 0 comments
Open

Please do not hardcode copy other Python libraries #3181

C0rn3j opened this issue Oct 9, 2024 · 0 comments

Comments

@C0rn3j
Copy link

C0rn3j commented Oct 9, 2024

This 884f766 commit takes https://github.com/JordanMilne/Advocate and instead of forking and putting it in requirements.txt, it hardcodes it into the code base.

Now, if any other project needs this dependency, they can't just take this maintained version, they have to roll their own, and there will be no collaboration possible.

Please do a fork as is custom (and as the previousmaintainer requested), package it and add it as a dependency to this project.

~ Sincerely, someone who very recently spent a very large amount of time removing ancient integrated libraries from a project I took over, and I am not even done with it yet.

EDIT: I see this is not the only bundled library - https://github.com/janeczku/calibre-web/tree/master/cps/cw_login

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant