Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path going straight through hole #84

Closed
Ake-Wettergren opened this issue Dec 5, 2023 · 1 comment
Closed

Path going straight through hole #84

Ake-Wettergren opened this issue Dec 5, 2023 · 1 comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@Ake-Wettergren
Copy link

I'm getting a path that runs straight through a hole. Technically it doesn't cross any of the edges of the hole, but runs along edges and crosses both in and out at vertices, so I gueses the issue is with checking edge crossings for visibility.

Setup to reproduce:

from extremitypathfinder.plotting import PlottingEnvironment

environment = PlottingEnvironment(plotting_dir="path\to\folder")

area = [(161.0, 47.0), (247.0, 47.0), (247.0, 7.0), (361.0, 7.0), (361.0, 441.0), (7.0, 441.0), (7.0, 7.0), (161.0, 7.0)]
holes = [[(272.0, 172.0), (272.0, 36.0), (136.0, 36.0), (136.0, 172.0), (155.6, 172.0), (155.6, 332.4), (252.4, 332.4), (252.4, 172.0)]]
(environment.graph, obj_dict) = PlottingEnvironment.get_graph(area, holes)
environment.save(obj_dict)

(start, end) = (50.004004, 44.004004), (318.004004, 44.004004)
sequence, sequence_length = environment.find_shortest_path(start, end)

graph_path_plot_1701788345

@jannikmi jannikmi added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Dec 5, 2023
@jannikmi
Copy link
Owner

After having a closer look I realisted this is duplicate to #23 (comment)

The related work progress is tracked in issue #24

I clarified this current edge case in the documentation: https://extremitypathfinder.readthedocs.io/en/latest/3_about.html#edge-case-overlapping-vertices-and-edges

@jannikmi jannikmi added duplicate This issue or pull request already exists enhancement New feature or request and removed bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants