Merge pull request #142 from gitgrimbo/issue-124

Use parseInt on phaseInterval cookie value
janodvarko · Jan 12, 2019 · 579969c · 579969c
2 parents 65a9649 + 0bd5c65
commit 579969c
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/webapp/scripts/preview/requestList.js b/webapp/scripts/preview/requestList.js
@@ -537,9 +537,11 @@ RequestList.prototype = domplate(
         this.phases = [];
 
         // The phase interval is customizable through a cookie.
-        var phaseInterval = Cookies.getCookie("phaseInterval");
-        if (!phaseInterval)
+        // parseInt(undefined, null, non-numeric string) === NaN
+        var phaseInterval = parseInt(Cookies.getCookie("phaseInterval"));
+        if (isNaN(phaseInterval)) {
             phaseInterval = 4000;
+        }
 
         var phase = null;