Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIO] No client side ping-pong #187

Open
hifi opened this issue Jun 10, 2021 · 0 comments
Open

[AIO] No client side ping-pong #187

hifi opened this issue Jun 10, 2021 · 0 comments

Comments

@hifi
Copy link

hifi commented Jun 10, 2021

IRC servers PING clients if the TCP connection is idle to ensure dead streams are dropped. On the other hand clients need to do the same to detect the same issue if they don't get anything from servers for a good while.

Currently no client side ping is implemented and if the socket stalls it will only be detected by the TCP stack when you try to send something and you immediately get disconnected. This is not ideal when you want to stay connected.

I have a local implementation for the AIO client currently implemented as a Protocol: https://github.com/hifi/heisenbridge/blob/master/heisenbridge/irc.py#L12

Let me know if this can be worked upstream somehow. It has been field tested by now that it seems to do about the right thing.

@hifi hifi changed the title No client side ping-pong [AIO] No client side ping-pong Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant