You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My implementation is currently ugly but the requirement remains that registration needs to be split out either optionally (arg for connect to disable?) or by changing the API to require calling register() after connect().
I can PR an accepted solution.
The text was updated successfully, but these errors were encountered:
hifi
changed the title
Registering a connection needs to be split out of connect()
[AIO] Registering a connection needs to be split out of connect()
Jun 10, 2021
To implement CAP negotiations (for SASL) before registering a connection I had to split connection registration out of
AioConnection::connect()
: https://github.com/hifi/heisenbridge/blob/master/heisenbridge/irc.py#L120My implementation is currently ugly but the requirement remains that registration needs to be split out either optionally (arg for connect to disable?) or by changing the API to require calling
register()
afterconnect()
.I can PR an accepted solution.
The text was updated successfully, but these errors were encountered: