Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIO] Registering a connection needs to be split out of connect() #189

Open
hifi opened this issue Jun 10, 2021 · 1 comment
Open

[AIO] Registering a connection needs to be split out of connect() #189

hifi opened this issue Jun 10, 2021 · 1 comment

Comments

@hifi
Copy link

hifi commented Jun 10, 2021

To implement CAP negotiations (for SASL) before registering a connection I had to split connection registration out of AioConnection::connect(): https://github.com/hifi/heisenbridge/blob/master/heisenbridge/irc.py#L120

My implementation is currently ugly but the requirement remains that registration needs to be split out either optionally (arg for connect to disable?) or by changing the API to require calling register() after connect().

I can PR an accepted solution.

@hifi
Copy link
Author

hifi commented Jun 10, 2021

I'll take the ugly part back, I refactored it to expect() flow.

@hifi hifi changed the title Registering a connection needs to be split out of connect() [AIO] Registering a connection needs to be split out of connect() Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant