Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making AioConnection.connect a coroutine and other small fixes #149

Merged
merged 2 commits into from
Aug 1, 2018
Merged

making AioConnection.connect a coroutine and other small fixes #149

merged 2 commits into from
Aug 1, 2018

Conversation

MattBroach
Copy link
Contributor

This PR is really more of a stopgap until @zinsserzh implements what he's planning in this issue, but I was butting up against some of the very limitations he was talking about and decided to roll out a patch to address them in the short term. Specifically:

  • As suggested, makes AioConnection.connect a coroutine, which allows for reconnecting after loop.run_forever has been called. Since overwriting the AioSimpleIRCClient.connect function to call loop.run_until_complete was pretty easy, this change was actually minimally disruptive
  • Adds a AioConnection.disconnect call to the IrcProtocol in the connection_lost function
  • Cleans up the various print functions I stupidly left in last time

@jaraco
Copy link
Owner

jaraco commented Jul 31, 2018

Looks good. Mind adding a CHANGES.rst entry? 0.1 bump probably.

@MattBroach
Copy link
Contributor Author

Of course! Updated.

@jaraco jaraco merged commit 4268620 into jaraco:master Aug 1, 2018
@jaraco
Copy link
Owner

jaraco commented Aug 1, 2018

Going out as 16.4. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants