making AioConnection.connect a coroutine and other small fixes #149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is really more of a stopgap until @zinsserzh implements what he's planning in this issue, but I was butting up against some of the very limitations he was talking about and decided to roll out a patch to address them in the short term. Specifically:
AioConnection.connect
a coroutine, which allows for reconnecting afterloop.run_forever
has been called. Since overwriting theAioSimpleIRCClient.connect
function to callloop.run_until_complete
was pretty easy, this change was actually minimally disruptiveAioConnection.disconnect
call to the IrcProtocol in theconnection_lost
functionprint
functions I stupidly left in last time