Use compatible eslint-config-react-app and eslint-plugin-react-hooks.

[ludofischer]

This solves the following warning on yarn install

[email protected]" has incorrect peer dependency "[email protected]".

[ludofischer]

I guess this is a breaking change for people who relied on the previous React hooks lint rules.

[agilgur5]

Yeaaa, it's probably breaking, but I'm not really sure why eslint-config-react-app didn't release a breaking change for it, it seems to change the rules in patches and minors per the changelogs 😕 There's also no individual changelog for this package in its directory.

Per the milestone added here and my comments in #889 , I was planning to release all the ESLint and Prettier upgrades as one breaking change together.

[agilgur5]

So the CI logs have a different warning now:

warning " > [email protected]" has incorrect peer dependency "[email protected] || 2.x".

🤔

But oddly enough they don't seem to show warnings for all the other peer deps that need upgrading if config-react-app is upgraded. Several more plugins would need to bumped per its current peerDeps

[agilgur5]

Ah, here's what the v5.2.1 peerDeps look like, which explains both the current warning and the lack of warnings. All the other changes (including addition of eslint-plugin-jest) seem to have been made after v5.2.1 and I guess not yet released?

EDIT: yes, they're only updated in the current pre-release line, @next

[ludofischer]

In light of the discussion in #634 I wonder if it would not be better in the future to inline eslint rules into tsdx own config. That way it would not be forced to wrangle with dependency combinations which in this case are somewhat arbitrary (as package versions reflect rule changes more often than compatibility with eslint versions). Also you would have more control over which new warnings to introduce.

[agilgur5]

I'm not sure that would really solve anything and may make TSDX actually have to make more breaking changes, because most rule changes (at least those to errors) are breaking. I also personally don't want to have to wrangle with opinionated rules, the feedback therein, etc -- folks who make configs already deal with that and I'd prefer to use their work instead of adding more work for myself (which is already plenty). Better to make things more maintainable instead of less maintainable

[agilgur5]

Minimally required change LGTM now. Double-checked and confirmed that there were no other breaking changes and basically no other changes in between 5.0.2 and 5.2.1

Thanks for the contribution!

[agilgur5]

@allcontributors please add @ludofischer for code

[allcontributors]

@agilgur5

I've put up a pull request to add @ludofischer! 🎉