Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Move "@types/react-dom" to devDependencies #22

Open
babblebey opened this issue Apr 2, 2024 · 2 comments
Open

Build: Move "@types/react-dom" to devDependencies #22

babblebey opened this issue Apr 2, 2024 · 2 comments
Labels
↗️ medium priority This issue is crucial good first issue Good for newcomers ✨ enhancement New feature or request

Comments

@babblebey
Copy link
Member

Currently, "@types/react-dom" is listed as a dependency in package.json. To align with good development practices, we should move "@types/react-dom" to devDependencies.

Steps:

  1. Open package.json file.
  2. Locate the "dependencies" section.
  3. Find the entry for "@types/react-dom" and cut it.
  4. Scroll down to the "devDependencies" section.
  5. Paste the "@types/react-dom" entry under "devDependencies".
  6. Save the package.json file.

Additional Steps:

  1. Run npm install to update the package-lock.json file with the changes made to package.json.

Additional Note:

  • Moving "@types/react-dom" to devDependencies ensures that it is only installed in the development environment, reducing the package size in production builds.
  • This should be easy for sure 😀 , feel free to ask question if you have any challenges following through the steps
@babblebey babblebey added ✨ enhancement New feature or request good first issue Good for newcomers ↗️ medium priority This issue is crucial labels Apr 2, 2024
@ShyneADL
Copy link
Contributor

Done this already, will include in my next PR

@babblebey
Copy link
Member Author

babblebey commented Nov 19, 2024

Done this already, will include in my next PR

Tiny changes are the best 😉, a PR for a Single Issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
↗️ medium priority This issue is crucial good first issue Good for newcomers ✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants