Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement content comparison before submitting changes in word-editor #38

Open
babblebey opened this issue Apr 13, 2024 · 0 comments
Open
Labels
↗️ medium priority This issue is crucial ✨ enhancement New feature or request

Comments

@babblebey
Copy link
Member

babblebey commented Apr 13, 2024

Currently, when submitting a new word or editing an existing word, the submission is processed without checking if any actual changes have been made to the content. This can lead to redundant operations and unnecessary updates to the dictionary. To improve efficiency, we should implement a content comparison check before submitting changes. This check should compare the new content with the existing content and only proceed with the submission if there are actual changes.

This enhancement is particularly needed in the edit existing word action; kindly refer to the PR #32 for context of the edit word action.

Related files:

Tasks:

  • Modify the concerned point, word-editor island or handleSubmitWord handler to include a content comparison check before submitting changes.
  • If no changes are detected, prevent the submission by disabling the submit button or displaying a message to the user indicating that no changes were made.
  • Ensure that the content comparison is thorough and accounts for all relevant fields and properties of the word.

Additional Information:

  • Consider adding visual indicators to the UI to highlight areas where changes have been made. (this one might be worth a separate issue on its own 😜)
  • Test the content comparison thoroughly to ensure it accurately detects changes and avoids false positives.
@babblebey babblebey added ✨ enhancement New feature or request ↗️ medium priority This issue is crucial labels Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
↗️ medium priority This issue is crucial ✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant