Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement logic to disable submission button in the editor when content is empty #42

Open
babblebey opened this issue Apr 14, 2024 · 3 comments · May be fixed by #112
Open

Implement logic to disable submission button in the editor when content is empty #42

babblebey opened this issue Apr 14, 2024 · 3 comments · May be fixed by #112
Assignees
Labels
↗️ medium priority This issue is crucial ✨ enhancement New feature or request

Comments

@babblebey
Copy link
Member

Currently, users can submit a new word without entering any content or title. To improve the quality of submissions, we should implement a logic that disables the submission button when either the content or title field is empty. Additionally, we should consider implementing a minimum input length requirement for the content field to ensure meaningful contributions.

Related Files:

Steps:

  1. Implement a check in the editor add new word action to disable the submission button if the content or title field is empty.
  2. Display a message or tooltip to inform users that both fields are required for submission.
  3. Consider implementing a minimum input length requirement for the content field (e.g., at least 50 characters).

Expected Behavior:

  • The submission button should be disabled if the content or title field is empty.
  • Users should receive a clear message or tooltip indicating that both fields are required.
  • The content field should require a minimum of 50 characters for submission.

Additional Information:

  • This enhancement will help improve the quality of contributions by ensuring that users provide meaningful content when submitting new words.
  • I thought that at least 50 characters can assure us of a meaningful content; is this too much or less!? kindly share your thought 😉
@babblebey babblebey added ✨ enhancement New feature or request ↗️ medium priority This issue is crucial labels Apr 14, 2024
@ShyneADL
Copy link
Contributor

I'd like to take on this issue,

@babblebey babblebey assigned babblebey and ShyneADL and unassigned babblebey Nov 18, 2024
@babblebey
Copy link
Member Author

Hey @ShyneADL, thank you for taking up this issue.

As you take this on, I have this possible edge cases in mind that I think we should factor in too

  1. SUBMISSION OF WORD EDITS: Unlike pretty Straightforward Scenario when user is submitting a new word to the dictionary, where we can check that word title and word content meets a certain minimum character count to enable submission.... I want us to look at cases of WORD EDITS where No changes was made in the existing word title and word content, we also want to disable the submission button in this case where we know that no changes was/is made yet

@babblebey
Copy link
Member Author

Hi @ShyneADL, How's it going with this? Need any help?? Please open a draft PR with your changes, and we can look at it together... I've got some thoughts around how to go about this implementation that I can share for sure 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
↗️ medium priority This issue is crucial ✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants