-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: going open source #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
babblebey
added a commit
that referenced
this pull request
Apr 26, 2024
### Description <!-- Please add PR description (don't leave blank) - example: This PR [adds/removes/fixes/replaces] the [feature/bug/etc] --> This Pull request implements some tiny changes carried over from #63 and addresses some todo that are simple enough. #### Changes Made - Implemented the submission visual cue on the word editor - this turns the submission loading button green after a word submission is successfully done before the redirection to he jargons editor dashboard - Added "babblebey" to funding/sponsor this project section - Extracted `addToRecentSearches` logic from `search` to `word.astro` layout - this ensures that words are added to recent searches when viewed and not only when they are searched using the search feature ### Related Issue <!-- Please prefix the issue number with Fixes/Resolves - example: Fixes #123 or Resolves #123 --> - Resolves #10 - #55 & #63 ### Screenshots/Screencasts <!-- Please provide screenshots or video recording that demos your changes (especially if it's a visual change) --> [screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.04.26-21_45_48.webm](https://github.com/babblebey/jargons.dev/assets/25631971/6ae8e447-9791-4de5-8ff9-46eb10bd2b8a) ### Notes to Reviewer <!-- Please state here if you added a new npm packages, or any extra information that can help reviewer better review you changes --> _NA_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request fulfils tasks required to take jargons.dev repo open source.
Changes Made
.vercel
folder to.gitignore
to avoid pushing build file to repodev/setup
script which help streamline creation of thejargons.dev-app
for user's testing, create a user's own.env
file and provides instruction on how to setup a test repo for development purposessetup
topackage.json
to allow user run thedev/setup
script on execution ofnpm run setup
commandRelated Issue
Resolves #55
Screencast/Screenshot
Coming soon page
📖