From 10aa66d29e68795b819e68997f355d02094e26e6 Mon Sep 17 00:00:00 2001 From: Jason Raimondi Date: Tue, 12 Feb 2019 22:00:33 -0800 Subject: [PATCH] Marking fields private. This helps the IDE (intellij) mark if the fields are used, it seems to have trouble and always mark fields as used even when they are not. --- src/renderer/app/Settings/Settings.tsx | 2 +- .../app/TrendingRepos/TrendingRepos.tsx | 8 ++++---- .../EmptyTrendingRepositoryList.tsx | 2 +- .../components/FrequencyPicker.tsx | 2 +- .../TrendingRepos/components/LanguageList.tsx | 2 +- .../components/RepositoryDetail.tsx | 20 +++++++++---------- .../components/RepositoryList.tsx | 2 +- .../elements/GithubAccessTokenForm.tsx | 2 +- src/renderer/elements/UserProfile.tsx | 2 +- .../elements/UserStarredRepositoryList.tsx | 6 +++--- 10 files changed, 24 insertions(+), 24 deletions(-) diff --git a/src/renderer/app/Settings/Settings.tsx b/src/renderer/app/Settings/Settings.tsx index 75e2831..06b688b 100644 --- a/src/renderer/app/Settings/Settings.tsx +++ b/src/renderer/app/Settings/Settings.tsx @@ -36,7 +36,7 @@ class Settings extends React.Component { }; } - get accessToken() { + private get accessToken() { if (this.props.settings.github) { return this.props.settings.github.accessToken; } diff --git a/src/renderer/app/TrendingRepos/TrendingRepos.tsx b/src/renderer/app/TrendingRepos/TrendingRepos.tsx index 057e9f1..d482515 100644 --- a/src/renderer/app/TrendingRepos/TrendingRepos.tsx +++ b/src/renderer/app/TrendingRepos/TrendingRepos.tsx @@ -121,15 +121,15 @@ class App extends React.Component { return language; } - get frequency() { + private get frequency() { return this.props.trending.options.frequency; } - get language() { + private get language() { return this.props.trending.options.language; } - get selectedTrend(): TrackUpdateSource | false { + private get selectedTrend(): TrackUpdateSource | false { const {repositoryList} = this.props.trending; if (repositoryList && repositoryList[this.language.value] @@ -140,7 +140,7 @@ class App extends React.Component { return false; } - get trendingRepositoryList(): RepositoryEntity[] { + private get trendingRepositoryList(): RepositoryEntity[] { return this.selectedTrend ? this.selectedTrend.data : []; } diff --git a/src/renderer/app/TrendingRepos/components/EmptyTrendingRepositoryList.tsx b/src/renderer/app/TrendingRepos/components/EmptyTrendingRepositoryList.tsx index f6029be..fd851b8 100644 --- a/src/renderer/app/TrendingRepos/components/EmptyTrendingRepositoryList.tsx +++ b/src/renderer/app/TrendingRepos/components/EmptyTrendingRepositoryList.tsx @@ -11,7 +11,7 @@ interface Props { } export class EmptyTrendingRepositoryList extends React.Component { - get githubLink(): string { + private get githubLink(): string { return `https://github.com/trending/${this.props.language.value}?since=${this.props.frequency}`; } diff --git a/src/renderer/app/TrendingRepos/components/FrequencyPicker.tsx b/src/renderer/app/TrendingRepos/components/FrequencyPicker.tsx index 5f47ccf..f91b2a3 100644 --- a/src/renderer/app/TrendingRepos/components/FrequencyPicker.tsx +++ b/src/renderer/app/TrendingRepos/components/FrequencyPicker.tsx @@ -43,7 +43,7 @@ export class FrequencyPicker extends React.Component { this.setState({ frequency }, () => this.props.handleSetFrequency(frequency)); } - get list() { + private get list() { return ['daily', 'weekly', 'monthly', 'yearly'].map((frequency: FrequencyType) => { const frequencyTitleCase = frequency.replace(/^\w/, (c) => c.toUpperCase()); const selectedClass = this.props.frequency === frequency ? 'selected' : null; diff --git a/src/renderer/app/TrendingRepos/components/LanguageList.tsx b/src/renderer/app/TrendingRepos/components/LanguageList.tsx index f85de3b..5c22e9c 100644 --- a/src/renderer/app/TrendingRepos/components/LanguageList.tsx +++ b/src/renderer/app/TrendingRepos/components/LanguageList.tsx @@ -20,7 +20,7 @@ interface Props { } export class LanguageList extends React.Component { - get languageList() { + private get languageList() { let languageList = this.props.popularLanguageList; if (this.props.languageListType === 'all') { diff --git a/src/renderer/app/TrendingRepos/components/RepositoryDetail.tsx b/src/renderer/app/TrendingRepos/components/RepositoryDetail.tsx index bb97ee9..67625a2 100644 --- a/src/renderer/app/TrendingRepos/components/RepositoryDetail.tsx +++ b/src/renderer/app/TrendingRepos/components/RepositoryDetail.tsx @@ -12,31 +12,31 @@ interface Props { } export class RepositoryDetail extends React.Component { - get attributes() { + private get attributes() { return this.repository.attributes; } - get repository() { + private get repository() { return this.props.repository; } - get stargazerLink() { + private get stargazerLink() { const login = this.attributes && this.attributes.owner && this.attributes.owner.login ? this.attributes.owner.login : 'Unknown'; return {login.replace('/', ' / ')}; } - get name() { + private get name() { const name = this.attributes && this.attributes.name ? this.attributes.name : 'Unknown'; return {name}; } - get language() { + private get language() { const language = this.attributes && this.attributes.language ? this.attributes.language : 'Unknown'; return {language}; } - get description() { + private get description() { const description = this.attributes ? this.attributes.description : false; if (description) { return {description}; @@ -44,7 +44,7 @@ export class RepositoryDetail extends React.Component { return null; } - get forksCount() { + private get forksCount() { const forksCount = this.attributes && this.attributes.forksCount ? this.attributes.forksCount : 0; const title = `${forksCount} Forks`; return @@ -53,7 +53,7 @@ export class RepositoryDetail extends React.Component { ; } - get watchersCount() { + private get watchersCount() { const watchersCount = this.attributes && this.attributes.watchersCount ? this.attributes.watchersCount : 0; const title = `${watchersCount} Watchers`; return @@ -62,7 +62,7 @@ export class RepositoryDetail extends React.Component { ; } - get stargazersCount() { + private get stargazersCount() { const stargazersCount = this.attributes && this.attributes.stargazersCount ? this.attributes.stargazersCount : 0; const title = `${stargazersCount} Stargazers`; return @@ -71,7 +71,7 @@ export class RepositoryDetail extends React.Component { ; } - get htmlUrl() { + private get htmlUrl() { return this.attributes && this.attributes.htmlUrl ? this.attributes.htmlUrl : null; } diff --git a/src/renderer/app/TrendingRepos/components/RepositoryList.tsx b/src/renderer/app/TrendingRepos/components/RepositoryList.tsx index ae5f426..781a8e3 100644 --- a/src/renderer/app/TrendingRepos/components/RepositoryList.tsx +++ b/src/renderer/app/TrendingRepos/components/RepositoryList.tsx @@ -19,7 +19,7 @@ export class RepositoryList extends React.Component { static readonly STARGAZERS_ICON = require('@/assets/icons/icon-star.svg'); static readonly WATCHERS_ICON = require('@/assets/icons/icon-user-circle.svg'); - get listItems() { + private get listItems() { if (this.props.repositoryList.length === 0 && this.props.emptyRepositoryList) { return this.props.emptyRepositoryList; } diff --git a/src/renderer/elements/GithubAccessTokenForm.tsx b/src/renderer/elements/GithubAccessTokenForm.tsx index e6b1431..1648b8b 100644 --- a/src/renderer/elements/GithubAccessTokenForm.tsx +++ b/src/renderer/elements/GithubAccessTokenForm.tsx @@ -44,7 +44,7 @@ export class GithubAccessTokenForm extends React.Component { setTimeout(() => setSubmitting(false), 500); } - get githubLink() { + private get githubLink() { const dateString = dayjs().format('YYYY-MM-DD'); const description = encodeURIComponent(`Traverse ${dateString}`); const scopes = [ diff --git a/src/renderer/elements/UserProfile.tsx b/src/renderer/elements/UserProfile.tsx index f0f2f67..82b1f8d 100644 --- a/src/renderer/elements/UserProfile.tsx +++ b/src/renderer/elements/UserProfile.tsx @@ -7,7 +7,7 @@ interface Props { } export class UserProfile extends React.Component { - get user() { + private get user() { return this.props.user; } diff --git a/src/renderer/elements/UserStarredRepositoryList.tsx b/src/renderer/elements/UserStarredRepositoryList.tsx index 2dc02d0..63c8195 100644 --- a/src/renderer/elements/UserStarredRepositoryList.tsx +++ b/src/renderer/elements/UserStarredRepositoryList.tsx @@ -20,11 +20,11 @@ interface Props { } export class UserStarredRepositoryList extends React.Component { - get user() { + private get user() { return this.props.user; } - get login() { + private get login() { return this.user && this.user.attributes.login ? this.user.attributes.login : false; } @@ -34,7 +34,7 @@ export class UserStarredRepositoryList extends React.Component { } } - get repositoryList() { + private get repositoryList() { return this.props.repositoryList; }