Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the explanations #56

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Disable the explanations #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
faf761a
Disable the explanations
JTPetter Sep 13, 2023
6477cc4
Add TODO instead of deleting placeholder
JTPetter Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/LSTdecisionTree.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ LSTdecisionTree <- function(jaspResults, dataset = NULL, options) {

jaspResults[["DecisionTree"]] <- createJaspContainer("")
jaspResults[["DecisionTree"]][["Heading"]] <- plot1
jaspResults[["DecisionTree"]][["Text"]] <- createJaspHtml("Some explanation and maybe a link to the test?", "p")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the idea is that there should be actual text in here at some point (just now now), I would leave this as a comment like:

  # jaspResults[["DecisionTree"]][["Text"]] <- createJaspHtml("Some explanation and maybe a link to the test?", "p") # TODO: write an informative explanation.

The word TODO is easy to search for.

If there should never be any text here, then I would indeed remove it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't discuss this with anyone yet, but IMO there should be some text and (if possible) a link to test or at least a description where to find it in JASP. So I'll do as you suggested!

# jaspResults[["DecisionTree"]][["Text"]] <- createJaspHtml("placeholder", "p") #TODO: Write an informative explanation for each test and where to find it in JASP (maybe even create a link if possible).

# create decision tree plot
if (options[["displayFullTree"]]) {
Expand Down
9 changes: 8 additions & 1 deletion inst/qml/LSTPValues.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,13 @@ Form
Section
{
title: qsTr("Options")
CheckBox { name: "introText"; label: qsTr("Introductory text") }

CheckBox
{
name: "introText"
label: qsTr("Introductory text")
checked: false
enabled: false
}
}
}
9 changes: 6 additions & 3 deletions inst/qml/LSTcentralLimitTheorem.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ Form
{
name: "parentExplain"
label: qsTr("Show explanatory text")
checked: true
checked: false
enabled: false
}
}

Expand Down Expand Up @@ -179,7 +180,8 @@ Form
{
name: "samplesExplain"
label: qsTr("Show explanatory text")
checked: true
checked: false
enabled: false
}

DoubleField
Expand Down Expand Up @@ -279,7 +281,8 @@ Form
{
name: "samplingDistExplain"
label: qsTr("Show explanatory text")
checked: true
checked: false
enabled: false
}
}

Expand Down
2 changes: 2 additions & 0 deletions inst/qml/LSTdescriptives.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,8 @@ Form
{
name: "LSdescExplanation"
label: qsTr("Show explanation")
checked: false
enabled: false
}
}
}
Expand Down
6 changes: 4 additions & 2 deletions inst/qml/LSTsampleVariability.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ Form
{
name: "parentExplain"
label: qsTr("Show explanatory text")
checked: true
checked: false
enabled: false
}
}

Expand Down Expand Up @@ -249,7 +250,8 @@ Form
{
name: "samplesExplain"
label: qsTr("Show explanatory text")
checked: true
checked: false
enabled: false
}

DoubleField
Expand Down
9 changes: 6 additions & 3 deletions inst/qml/LSTstandardError.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ Form
{
name: "parentExplain"
label: qsTr("Show explanatory text")
checked: true
checked: false
enabled: false
}
}

Expand Down Expand Up @@ -187,7 +188,8 @@ Form
{
name: "samplesExplain"
label: qsTr("Show explanatory text")
checked: true
checked: false
enabled: false
}

DoubleField
Expand Down Expand Up @@ -287,7 +289,8 @@ Form
{
name: "samplingDistExplain"
label: qsTr("Show explanatory text")
checked: true
checked: false
enabled: false
}
}

Expand Down
Loading