From add26560607c6e5c788be867a23b8c69c1c5e6ed Mon Sep 17 00:00:00 2001
From: maltelueken <malte_lueken@arcor.de>
Date: Fri, 10 Nov 2023 09:19:58 +0100
Subject: [PATCH] Fix graph and lavaan model validation

---
 R/classicProcess.R | 29 ++++++++++++++++++++---------
 1 file changed, 20 insertions(+), 9 deletions(-)

diff --git a/R/classicProcess.R b/R/classicProcess.R
index c2f2b81..4a53800 100644
--- a/R/classicProcess.R
+++ b/R/classicProcess.R
@@ -133,10 +133,10 @@ ClassicProcess <- function(jaspResults, dataset = NULL, options) {
       graph <- try(.procModelGraphSingleModel(options[["processModels"]][[i]], globalDependent = options[["dependent"]]))
       state <- createJaspState(object = graph)
       state$dependOn(
+        options = .procGetDependencies(),
         optionContainsValue = list(processModels = modelOptions),
         nestedOptions = .procGetSingleModelsDependencies(as.character(i))
       )
-      
       modelsContainer[[modelName]][["graph"]] <- state
     }
   }
@@ -575,7 +575,8 @@ ClassicProcess <- function(jaspResults, dataset = NULL, options) {
     modelName <- modelOptions[["name"]]
 
     graph <- modelsContainer[[modelName]][["graph"]]$object
-    if (inherits(graph, "try-error")) next
+    
+    if (!.procCheckGraph(graph)) next
 
     if (is.null(modelsContainer[[modelName]][["syntax"]])) {
       graph <- .procGraphAddParNamesSingleModel(graph)
@@ -641,12 +642,13 @@ ClassicProcess <- function(jaspResults, dataset = NULL, options) {
     modelOptions <- options[["processModels"]][[i]]
     modelName <- modelOptions[["name"]]
 
-    if (inherits(modelsContainer[[modelName]][["graph"]]$object, "try-error")) next
+    if (!.procCheckGraph(modelsContainer[[modelName]][["graph"]]$object)) next
 
     if (is.null(modelsContainer[[modelName]][["modProbes"]])) {
       modProbes <- .procModProbesSingleModel(modelsContainer[[modelName]], dataset, options)
       state <- createJaspState(object = modProbes)
       state$dependOn(
+        options = .procGetDependencies(),
         optionContainsValue = list(processModels = modelOptions),
         nestedOptions = .procGetSingleModelsDependencies(as.character(i))
       )
@@ -698,13 +700,14 @@ ClassicProcess <- function(jaspResults, dataset = NULL, options) {
     modelName <- modelOptions[["name"]]
 
     if (
-      inherits(modelsContainer[[modelName]][["graph"]]$object, "try-error")
+      !.procCheckGraph(modelsContainer[[modelName]][["graph"]]$object)
     ) next
 
     if (is.null(modelsContainer[[modelName]][["resCovGraph"]])) {
       resCovGraph <- .procResCovGraphSingleModel(modelsContainer[[modelName]][["graph"]]$object, modelOptions)
       state <- createJaspState(object = resCovGraph)
       state$dependOn(
+        options = .procGetDependencies(),
         optionContainsValue = list(processModels = modelOptions),
         nestedOptions = .procGetSingleModelsDependencies(as.character(i))
       )
@@ -768,13 +771,14 @@ ClassicProcess <- function(jaspResults, dataset = NULL, options) {
     modelName <- modelOptions[["name"]]
 
     if (
-      inherits(modelsContainer[[modelName]][["graph"]]$object, "try-error")
+      !.procCheckGraph(modelsContainer[[modelName]][["graph"]]$object)
     ) next
 
     if (is.null(modelsContainer[[modelName]][["syntax"]])) {
       syntax <- .procModelSyntaxSingleModel(modelsContainer[[modelName]], modelOptions)
       state <- createJaspState(object = syntax)
       state$dependOn(
+        options = .procGetDependencies(),
         optionContainsValue = list(processModels = modelOptions),
         nestedOptions = .procGetSingleModelsDependencies(as.character(i))
       )
@@ -1070,8 +1074,12 @@ ClassicProcess <- function(jaspResults, dataset = NULL, options) {
   return(!any(unlist(encoding) %in% vars) && !any(grepl(encoding[["M"]], vars)))
 }
 
+.procCheckGraph <- function(graph) {
+  return(igraph::is.igraph(graph))
+}
+
 .procCheckFitModel <- function(graph) {
-  if (inherits(graph, "try-error")) return(FALSE)
+  if (!.procCheckGraph(graph)) return(FALSE)
   allSourcesValid <- .procCheckFitModelVars(igraph::E(graph)$source)
   allTargetsValid <- .procCheckFitModelVars(igraph::E(graph)$target)
   return(allSourcesValid && allTargetsValid)
@@ -1195,6 +1203,7 @@ ClassicProcess <- function(jaspResults, dataset = NULL, options) {
       }
       state <- createJaspState(object = fittedModel)
       state$dependOn(
+        options = .procGetDependencies(),
         optionContainsValue = list(processModels = modelOptions),
         nestedOptions = .procGetSingleModelsDependencies(as.character(i))
       )
@@ -1379,11 +1388,11 @@ ClassicProcess <- function(jaspResults, dataset = NULL, options) {
 }
 
 .procIsValidModel <- function(container, procResult) {
+  if (inherits(procResult, "lavaan")) return(TRUE)
   if (is.character(procResult)) {
     container$setError(procResult)
-    return(FALSE)
   }
-  return(TRUE)
+  return(FALSE)
 }
 
 .procParameterEstimateTables <- function(container, options, modelsContainer) {
@@ -1403,7 +1412,7 @@ ClassicProcess <- function(jaspResults, dataset = NULL, options) {
 
     isValid <- .procIsValidModel(modelContainer, procResults[[i]])
     
-    if (isValid && !procResults[[i]]@Options[["do.fit"]]) {
+    if (!isValid || !procResults[[i]]@Options[["do.fit"]]) {
       next
     }
 
@@ -2123,6 +2132,8 @@ ClassicProcess <- function(jaspResults, dataset = NULL, options) {
 
 .procLavToGraph <- function(container, type, estimates, options) {
   graph <- container[["graph"]]$object
+
+  if (!.procCheckGraph(graph)) return()
   
   if (type == "conceptual") {
     graph <- .procGraphLayoutConceptual(graph)