Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code is now broken for first edition of the book #20

Open
kanozad opened this issue Jan 15, 2018 · 3 comments
Open

Code is now broken for first edition of the book #20

kanozad opened this issue Jan 15, 2018 · 3 comments

Comments

@kanozad
Copy link

kanozad commented Jan 15, 2018

I have the first edition of the book. I just cloned the repo and tried to build with jdk8 and it's broken all over the place. Could you create a tag or branch for the Java 8 version?
@kanozad
Copy link
Author

kanozad commented Jan 15, 2018

I checked out the previous commit (ae8122) and it builds just fine with jdk8. If you create a tag or branch from that you should be good to go.

@vsushko
Copy link

vsushko commented Jun 10, 2018

git reset --hard ae8122f

@vbhosle
Copy link

vbhosle commented Jun 21, 2019

switch to previous commit to get first edition code.

git reset --hard ae8122f433f90a8bfed7244cdf6f99271f1d1125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kanozad @vsushko @vbhosle