Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code]: Sourcepath for getAdmonitionElement #314

Closed
mayurankv opened this issue Jul 5, 2023 · 0 comments · Fixed by #315
Closed

[Code]: Sourcepath for getAdmonitionElement #314

mayurankv opened this issue Jul 5, 2023 · 0 comments · Fixed by #315
Assignees

Comments

@mayurankv
Copy link

Scope

Currently, the getAdmonitionElement function renders markdown but returns an empty sourcePath so markdownPostProcessors get triggered but with no sourcePath context. This is an issue for postProcessors that wish to work with the admonitions plugin. I understand that the plugin renders things following this as well which do provide sourcePaths, but the getSectionInfo seems to only work on the render that returns an empty sourcePath.

If I'm misunderstanding why this should return an empty sourcePath, then apologies but if changing it to include a sourcePath isn't an issue, that would be greatly appreciated!

Discovery

Rather than returning '' to the sourcePath for the getAdmonitionElement function in main.ts line 424, return the actual sourcePath.

Validate

No changes should be required outside of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants