Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect dtype cast in Matmul Example? #174

Open
adam-hartshorne opened this issue Jun 17, 2023 · 0 comments
Open

Incorrect dtype cast in Matmul Example? #174

adam-hartshorne opened this issue Jun 17, 2023 · 0 comments

Comments

@adam-hartshorne
Copy link

In the example, jax-triton/examples/matmul.py on line 96,

c = accumulator.to(tl.float16)

However, on line 120, the dtype of the output is set to the same as the input i.e. jnp.float32

out_shape = jax.ShapeDtypeStruct(shape=(m, n), dtype=a.dtype)

Surely c should be just set to accumulator (which is a float32).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adam-hartshorne