Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make consuming this package easier? #12

Open
jaydp17 opened this issue Oct 29, 2017 · 2 comments
Open

Make consuming this package easier? #12

jaydp17 opened this issue Oct 29, 2017 · 2 comments

Comments

@jaydp17
Copy link
Owner

jaydp17 commented Oct 29, 2017

Currently, the usage involves getting an API_KEY from Google, which could be too much hassle for a lot of people.

Any alternate way to make it simpler?

Some of the things I've in mind

  • OAuth Sign in
  • Make my API_KEY public and ship it with the package ( not really sure how secure it is 😨 )

Your suggestions welcome ... 🙂

@daveseco7
Copy link

hi,
Google's API_KEY is required for API access and is subject to quotas. So if you make it public, another person can use it and mess up your service quota. So you should keep it secret.

If I understand correctly, your project consists in client-side code making calls to Google's API. So the best choice is to provide OAuth 2.0 auth. relevant link

@jaydp17
Copy link
Owner Author

jaydp17 commented Oct 30, 2017

Hey @daveseco7, thanks for the interest!

It does make sense to use OAuth.
I'd really appreciate if you can send in a PR implementing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants