Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StreamingHTTPResponse and hardcoded threshold #87

Open
ougeee opened this issue May 24, 2018 · 3 comments
Open

StreamingHTTPResponse and hardcoded threshold #87

ougeee opened this issue May 24, 2018 · 3 comments
Milestone

Comments

@ougeee
Copy link

ougeee commented May 24, 2018

Hi, I was wondering if you had a special reason to hardcode a very low threshold for returning a StreamingHTTPResponse instead of HTTPResponse.

To my understanding, the Django docs generally discourage the use of StreamingHTTPResponse:
https://docs.djangoproject.com/en/2.0/ref/request-response/#streaminghttpresponse-objects

How about making this user configurable and add the option not to use StreamingHTTPResponse at all?
I'd put together a PR for that in case you support the idea.

@seocam
Copy link
Contributor

seocam commented May 24, 2018

The reason is that this might proxy very big files and in those cases we had a major memory issue due to that.

@seocam
Copy link
Contributor

seocam commented May 24, 2018

Anyway I support the idea of allowing the user to choose what's the best MIN_STREAMING_LENGTH and maybe None meaning streaming shouldn't be used.

@ougeee
Copy link
Author

ougeee commented May 24, 2018 via email

@seocam seocam added this to the 1.0 milestone Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants