Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #458

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Feb 19, 2024

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (eac5cc3) to head (adf2e5c).
Report is 2 commits behind head on master.

Current head adf2e5c differs from pull request most recent head 086f9f6

Please upload reports for the commit 086f9f6 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   87.14%   87.14%           
=======================================
  Files           6        6           
  Lines         249      249           
  Branches       45       45           
=======================================
  Hits          217      217           
  Misses         15       15           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from d29c1b8 to adf2e5c Compare March 18, 2024 17:41
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 25ed1b1 to f9b64bc Compare April 15, 2024 17:44
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from f9b64bc to 69c60ab Compare April 29, 2024 17:45
@Pantzan
Copy link

Pantzan commented Jun 15, 2024

@claudep should we merge this PR, what is the policy in Jazzband regarding those PRs? Can I approve and merge it myself?

@claudep
Copy link
Contributor

claudep commented Jun 15, 2024

My personal position on this is that they pollute the git history for almost no gain, so generally I prefer merging them just before making a new release. I know other maintainers always merge them almost immediately. Tastes and such 🍰

@Pantzan
Copy link

Pantzan commented Jun 15, 2024

I agree with you, it does not provide much value to the code base at this stage so lets do it in a later stage.

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0)
- [github.com/psf/black: 24.1.1 → 24.4.2](psf/black@24.1.1...24.4.2)
- [github.com/PyCQA/flake8: 7.0.0 → 7.1.0](PyCQA/flake8@7.0.0...7.1.0)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 69c60ab to 086f9f6 Compare June 17, 2024 17:40
@claudep claudep merged commit d57a92c into master Jun 21, 2024
17 checks passed
@claudep claudep deleted the pre-commit-ci-update-config branch June 21, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants