Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated arguments on kmeans function call #222

Open
svthiago opened this issue Apr 18, 2022 · 5 comments
Open

Deprecated arguments on kmeans function call #222

svthiago opened this issue Apr 18, 2022 · 5 comments

Comments

@svthiago
Copy link

When I tried to use kmeans I noticed that a couple of deprecated arguments were used to make the function call: precompute_distances and n_jobs. After I removed them it worked fine. Tried both on version 1.1.0 and 1.0.9. I would make a PR about it but the code on the main branch looks different from the one installed with pip install.

@svthiago
Copy link
Author

This issue is happening on file representation.py lines 218 and 236.

@svthiago svthiago changed the title Deprecated arguments on kmeans Deprecated arguments on kmeans function call Apr 18, 2022
@jbesomi
Copy link
Owner

jbesomi commented Apr 20, 2022

Thanks, @svthiago. I will look into that and fix it soon. If you are interested to work on that and want to open a PR, that would be very appreciated!

@akthammomani
Copy link

@jbesomi Please let us know if there's any update in this error. Thanks for the support

@jbesomi
Copy link
Owner

jbesomi commented May 10, 2022

Hey @akthammomani. I can look into that during the weekend. If you happen to have some free time and feel like contributing, I would love to receive your PR 🎉

@akthammomani
Copy link

Hi @jbesomi, as pointed out by @svthiago: The code on the main branch is different from the one installed with pip install.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants