Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reset_connection_cache not deleting on disconnection failure. #248

Closed
NarinderS opened this issue Nov 17, 2023 · 2 comments
Closed

reset_connection_cache not deleting on disconnection failure. #248

NarinderS opened this issue Nov 17, 2023 · 2 comments

Comments

@NarinderS
Copy link

NarinderS commented Nov 17, 2023 •
edited
Loading

The reset_connection_cache function doesn't seem to delete a connection if it fails to disconnect first. So for example, if the connection had the wrong credentials, it sits around in the cache forever, unless deleted via delete_session.

The simplest solution would be to delete the connection, no matter if disconnection was successful, but I'm not sure if that would cause other issues.
@jborean93
Copy link
Owner

Thanks for the report, I'll try and fix it up when I get to looking at the current log of issues soon.

@jborean93
Copy link
Owner

Fixed by #291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jborean93 @NarinderS