Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smbclient.liststreams to enumerate ADS streams #294

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

mon
Copy link
Contributor

@mon mon commented Oct 14, 2024

A simple change in theory, let me know if I messed up anything with layout / documentation etc.

I haven't got a huge array of machines to test against, but it works on my test device.

Closes #292

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (42804ca) to head (a76c0eb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #294   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files          24       24           
  Lines        5117     5127   +10     
=======================================
+ Hits         5069     5079   +10     
  Misses         48       48           
Flag Coverage Δ
macOS 68.16% <60.00%> (-0.02%) ⬇️
py3.10 99.02% <100.00%> (+<0.01%) ⬆️
py3.11 99.02% <100.00%> (+<0.01%) ⬆️
py3.12 99.02% <100.00%> (+<0.01%) ⬆️
py3.8 99.02% <100.00%> (+<0.01%) ⬆️
py3.9 99.06% <100.00%> (+<0.01%) ⬆️
ubuntu 96.84% <100.00%> (+<0.01%) ⬆️
windows 98.98% <100.00%> (+<0.01%) ⬆️
x64 99.06% <100.00%> (+<0.01%) ⬆️
x86 98.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, have added some comments.

src/smbclient/_os.py Outdated Show resolved Hide resolved
src/smbclient/_os.py Show resolved Hide resolved
src/smbclient/_os.py Outdated Show resolved Hide resolved
src/smbclient/_os.py Show resolved Hide resolved
@mon
Copy link
Contributor Author

mon commented Oct 15, 2024

I find it interesting that the tests failed on the pre-3.9 lowercase list, when it's used elsewhere in the codebase, but I'll fix that

Just saw your first comment, that'd do it

@mon mon force-pushed the liststreams branch 2 times, most recently from 4bacbf5 to a99f1b3 Compare October 15, 2024 02:12
src/smbclient/_os.py Outdated Show resolved Hide resolved
src/smbclient/_os.py Show resolved Hide resolved
src/smbclient/_os.py Show resolved Hide resolved
src/smbclient/_os.py Outdated Show resolved Hide resolved
@jborean93
Copy link
Owner

Thanks for working on this!

@jborean93 jborean93 merged commit b6affa7 into jborean93:master Oct 15, 2024
22 checks passed
@mon mon deleted the liststreams branch October 15, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

smbclient: xattr commands set Extended Attributes. Should they use Alternate Data Streams instead?
2 participants