Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic module name #20

Open
dmlloyd opened this issue Jan 23, 2025 · 1 comment
Open

Automatic module name #20

dmlloyd opened this issue Jan 23, 2025 · 1 comment

Comments

@dmlloyd
Copy link
Member

dmlloyd commented Jan 23, 2025

This project needs an automatic module name (or a proper module descriptor). My suggestion would be org.apache.commons.logging.

Background: normally the module name would be automatically derived from the JAR name, or the group/artifact. But that gives commons.logging.jboss.logging or org.jboss.logging.commons.logging.jboss.logging, respectively, neither of which are good names.

Since this module is a drop-in replacement for the Apache project, its automatic module name should be the same so that dependency resolution will find the replacement library at run time. The upstream project uses the automatic module name of org.apache.commons.logging; so should we.

@jamezp
Copy link
Member

jamezp commented Jan 23, 2025

+1 this makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants