Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISL3295ExHZ-T, ISL3298ExRTZ-T #1

Closed
justyn opened this issue Aug 19, 2020 · 3 comments
Closed

Add ISL3295ExHZ-T, ISL3298ExRTZ-T #1

justyn opened this issue Aug 19, 2020 · 3 comments
Assignees

Comments

@justyn
Copy link
Contributor

justyn commented Aug 19, 2020

Please check or create these parts:

  • ISL3295ExHZ-T
  • ISL3298ExRTZ-T

Please copy and paste the text in the box below into a new comment where it says "Leave a comment" at the bottom of the page, then click the "Comment" button.

After this, you can use the mouse to click on each checkbox after each item is complete or verified.

- [ ] Make sure your name and email address are set up in git on your computer.

### Step 1: Check for symbols and parts in official libraries

- [ ] Check whether the required parts exist.
- [ ] Check whether an identical part exists with a different part number. These should be added as an [alias](https://kicad-pcb.org/libraries/klc/S6.2/).

If either the symbol or footprint already exists, check that:

- [ ] Symbol and footprint are correct and suitable according to the datasheet.
- [ ] Symbol has the [footprint filter properly set](https://kicad-pcb.org/libraries/klc/S5.2/).
- [ ] Symbol and footprint pin mapping is correct for this part.
- [ ] Footprint has a [3D model set](https://kicad-pcb.org/libraries/klc/F9.3/).

### Step 2: Create/modify required parts

- [ ] Make or modify the parts according to the [Kicad Library Conventions](https://kicad-pcb.org/libraries/klc/).
- [ ] **symbols**: add a link to the datasheet.
- [ ] **symbols**: fully set the [footprint filter](https://kicad-pcb.org/libraries/klc/S5.2/).
- [ ] **symbols**: set any pin-identical parts in the same datasheet as an [alias](https://kicad-pcb.org/libraries/klc/S6.2/).
- [ ] **footprints**: check whether the footprint should be created by modifying some values in [kicad-footprint-generator](https://github.com/pointhi/kicad-footprint-generator/) (also see [here](https://kicad-pcb.org/libraries/contribute/#_footprint_creation_scripts)).
- [ ] **footprints**: set a 3D model [even if the model doesn't exist](https://kicad-pcb.org/libraries/klc/F9.3/).

### Step 3: Create Pull Request in kicad official libraries

- [ ] Follow instructions for [making a Pull Request](https://kicad-pcb.org/libraries/contribute/#_making_a_pull_request) using your own fork of [kicad-symbols](https://github.com/KiCad/kicad-symbols) or [kicad-footprints](https://github.com/KiCad/kicad-footprints).

If you've created a footprint and a symbol, a Pull Request will be required in each one.

- [ ] Place the part in the correct `.pretty` directory (for a footprint) or inside the correct new or existing `.lib` file (for a symbol).
- [ ] Add a screenshot to your Pull Requests [like this](https://kicad-pcb.org/img/klc/adding_screenshot.png).
- [ ] Add a **link to this issue** in the Pull Requests.
- [ ] Fix any detected problems when you create the Pull Request, and commit the changes.
- [ ] If the footprint was created with [kicad-footprint-generator](https://github.com/pointhi/kicad-footprint-generator/), create a Pull Request with the new values in [that repository](https://github.com/pointhi/kicad-footprint-generator/) first.

### Step 4: Create Pull Request in kicad-jb-public

For the [kicad-jb-public](https://github.com/jbots/kicad-jb-public) repository, both symbol and footprint are added to the **same repository**.

The rules for where to place the parts are different to those for the official libraries:

- [ ] **symbols**: create a **new** `.lib` file for the part in the `sym` directory. The lib name should be descriptive, and doesn't have to be the same as it is in kicad-symbols.
- [ ] **footprints**: create a new `.kicad_mod` file in the `fp.pretty` directory.

- [ ] Create a Pull Request in this repository with the part number as the title and a link to this issue in the text.

### Step 5: Follow instructions of Kicad librarians

- [ ] Make any changes required by the Kicad librarians to make the part suitable for inclusion in the official libraries.
@justyn justyn changed the title ISL3295ExHZ-T, ISL3298ExRTZ-T Add ISL3295ExHZ-T, ISL3298ExRTZ-T Aug 19, 2020
UsairemAlamgeer added a commit to UsairemAlamgeer/kicad-footprints that referenced this issue Aug 19, 2020
Footprints along with 3D models have been added for ISL3298ExRTZ and ISL32956ExHZ RTC485 ICs.

Description: RS-422/RS-485 Interface IC 6LD SNG RS-485 DRVR FAST SPD IND

Mounting Style: SMD/SMT

Package Casing: SOT-23-6

 The packages included are SOT-23-3_B2.8x2.9x1.45mm_P0.95mm and TDFN-8_B2.0x3.0x0.75mm_P0.5 respectively.

Datasheet: https://eu.mouser.com/datasheet/2/698/isl3295e-98e-1697114.pdf

Link to Repo Issue: jbots/kicad-jb-public#1
@UsairemAlamgeer
Copy link
Collaborator

UsairemAlamgeer commented Aug 19, 2020

Step 1: Check for symbols and parts in official libraries

  • Check whether the required parts exist.
  • Check whether an identical part exists with a different part number. These should be added as an alias.

If either the symbol or footprint already exists, check that:

  • Symbol and footprint are correct and suitable according to the datasheet.
  • Symbol has the footprint filter properly set.
  • Symbol and footprint pin mapping is correct for this part.
  • Footprint has a 3D model set.

Step 2: Create/modify required parts

Step 3: Create Pull Request in kicad official libraries

If you've created a footprint and a symbol, a Pull Request will be required in each one.

  • Place the part in the correct .pretty directory (for a footprint) or inside the correct new or existing .lib file (for a symbol).
  • Add a screenshot to your Pull Requests like this.
  • Add a link to this issue in the Pull Requests.
  • Fix any detected problems when you create the Pull Request, and commit the changes.
  • If the footprint was created with kicad-footprint-generator, create a Pull Request with the new values in that repository first.

Step 4: Create Pull Request in kicad-jb-public

For the kicad-jb-public repository, both symbol and footprint are added to the same repository.

The rules for where to place the parts are different to those for the official libraries:

  • symbols: create a new .lib file for the part in the sym directory. The lib name should be descriptive, and doesn't have to be the same as it is in kicad-symbols.

  • footprints: create a new .kicad_mod file in the fp.pretty directory.

  • Create a Pull Request in this repository with the part number as the title and a link to this issue in the text.

Step 5: Follow instructions of Kicad librarians

  • Make any changes required by the Kicad librarians to make the part suitable for inclusion in the official libraries.

ISL3295ExHZ-T AND ISL3298ExRTZ-T.zip

@justyn
Copy link
Contributor Author

justyn commented Aug 20, 2020

New symbols pull request at KiCad/kicad-symbols#2922

@justyn
Copy link
Contributor Author

justyn commented Aug 24, 2020

Merged into kicad-symbols@35beb60

@justyn justyn closed this as completed Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants