Update Rubocop config, fix offenses

Author: n-rodriguez

.rubocop.yml

@@ -12,7 +12,7 @@ AllCops:
   Exclude:
     - bin/*
     - gemfiles/*
-    - spec/**/*
+    - spec/dummy/**/*
     - lib/generators/**/*.rb
 
 Gemspec/RequireMFA:
@@ -94,3 +94,29 @@ Metrics/BlockLength:
 
 Metrics/BlockNesting:
   Enabled: false
+
+#########
+# RSPEC #
+#########
+
+RSpec/NotToNot:
+  EnforcedStyle: to_not
+
+RSpec/ExampleLength:
+  Max: 9
+
+RSpec/MultipleExpectations:
+  Max: 4
+
+RSpec/MetadataStyle:
+  EnforcedStyle: hash
+
+############
+# CAPYBARA #
+############
+
+Capybara/NegationMatcher:
+  EnforcedStyle: not_to
+
+Capybara/ClickLinkOrButtonStyle:
+  EnforcedStyle: strict

spec/config_capybara.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 def register_driver(driver_name, args = [])
   opts = { js_errors: true, headless: true, window_size: [1920, 1200], browser_options: {} }
   args.each do |arg|

spec/config_rspec.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 # Configure RSpec
 RSpec.configure do |config|
   config.include WaitForAjax, type: :feature
 
-  config.fixture_path = "#{::Rails.root}/fixtures"
+  config.fixture_path = Rails.root.join('fixtures')
   config.use_transactional_fixtures = false
   config.infer_spec_type_from_file_location!
 
@@ -25,16 +27,16 @@
     DatabaseCleaner.strategy = :truncation
   end
 
-  config.before(:each) do
+  config.before do
     DatabaseCleaner.start
   end
 
-  config.after(:each) do
+  config.after do
     DatabaseCleaner.clean
   end
 
   if ENV.key?('GITHUB_ACTIONS')
-    config.around(:each) do |ex|
+    config.around do |ex|
       ex.run_with_retry retry: 3
     end
   end

spec/features/custom_filters_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.feature 'Combine custom filtering' do
@@ -6,65 +8,65 @@
   scenario 'The user search user, change pagination and change page', js: true do
     visit admin_users_path
 
-    #page_sizes => [3, 10]
-    within(".pagination-per-page") { click_on "10" }
-    expect(page).to have_selector('tr.editable', count: 8)
+    # page_sizes => [3, 10]
+    within('.pagination-per-page') { click_link '10' }
+    expect(page).to have_css('tr.editable', count: 8)
 
-    fill_in "filter", with: "test"
+    fill_in 'filter', with: 'test'
     sleep 1
-    expect(page).to have_selector('tr.editable', count: 4)
+    expect(page).to have_css('tr.editable', count: 4)
 
-    within(".pagination-per-page") { click_on "3" }
-    within(".pagination") { click_on "2" }
-    expect(page).to have_selector('tr.editable', count: 1)
+    within('.pagination-per-page') { click_link '3' }
+    within('.pagination') { click_link '2' }
+    expect(page).to have_css('tr.editable', count: 1)
   end
 
   scenario 'The user sort users and change page', js: true do
     visit admin_users_path
 
     find('.name a.sortable').click
-    expect(page).to have_content("Aaron")
-    expect(page).to_not have_content("Jane")
+    expect(page).to have_content('Aaron')
+    expect(page).to_not have_content('Jane')
 
-    within(".pagination") { click_on "2" }
-    expect(page).to have_content("Jane")
-    expect(page).to_not have_content("Aaron")
+    within('.pagination') { click_link '2' }
+    expect(page).to have_content('Jane')
+    expect(page).to_not have_content('Aaron')
   end
 
   scenario 'The user combine filters', js: true do
     visit admin_users_path
 
-    fill_in "filter", with: "email"
+    fill_in 'filter', with: 'email'
     find('input#boolean').click
-    expect(page).to have_selector('tr.editable', count: 2)
+    expect(page).to have_css('tr.editable', count: 2)
   end
 
   scenario 'The user combine filters and sort users', js: true do
     visit admin_users_path
 
-    fill_in "filter", with: "test"
+    fill_in 'filter', with: 'test'
     find('input#boolean').click
     wait_for_ajax
-    expect(page).to have_selector('tr.editable', count: 2)
+    expect(page).to have_css('tr.editable', count: 2)
 
     click_link 'Name'
-    expect(page).to have_selector('tr.editable', count: 2)
-    expect(page.find(:css, "tbody > tr:nth-child(1)")).to have_content("Edward")
-    expect(page.find(:css, "tbody > tr:nth-child(2)")).to have_content("Robin")
+    expect(page).to have_css('tr.editable', count: 2)
+    expect(page.find(:css, 'tbody > tr:nth-child(1)')).to have_content('Edward')
+    expect(page.find(:css, 'tbody > tr:nth-child(2)')).to have_content('Robin')
   end
 
   scenario 'The user combine filters, sort and change page', js: true do
     visit admin_users_path
 
     check 'boolean'
     wait_for_ajax
-    expect(find(:css, '.email a.sortable')[:href]).to include("boolean")
+    expect(find(:css, '.email a.sortable')[:href]).to include('boolean')
 
     click_link 'Email'
-    expect(page.find(:css, "tbody > tr:nth-child(2)")).to have_content("Lisa")
+    expect(page.find(:css, 'tbody > tr:nth-child(2)')).to have_content('Lisa')
 
-    within(".pagination") { click_on "2" }
-    expect(page.find(:css, "tbody > tr:nth-child(1)")).to have_content("Robin")
-    expect(page.find(:css, '.count')).to have_content("4")
+    within('.pagination') { click_link '2' }
+    expect(page.find(:css, 'tbody > tr:nth-child(1)')).to have_content('Robin')
+    expect(page.find(:css, '.count')).to have_content('4')
   end
 end

spec/features/manage_items_spec.rb

@@ -1,46 +1,48 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
-RSpec.feature "Manage items" do
-  scenario "Add a new item", js: true do
+RSpec.feature 'Manage items' do
+  scenario 'Add a new item', js: true do
     visit admin_users_path
 
-    click_on "New item"
-    fill_in "Name", with: "Test name"
-    fill_in "Email", with: "Test email"
-    click_on "Save"
+    click_link 'New item'
+    fill_in 'Name', with: 'Test name'
+    fill_in 'Email', with: 'Test email'
+    click_button 'Save'
 
-    expect(page).to have_content("Test name")
+    expect(page).to have_content('Test name')
   end
 
-  scenario "Edit an item", js: true do
-    User.create(name: "Name 1", email: "Email 1")
+  scenario 'Edit an item', js: true do
+    User.create(name: 'Name 1', email: 'Email 1')
     visit admin_users_path
 
     find('.edit').click
-    fill_in "Name", with: "Name 2"
-    fill_in "Email", with: "Email 2"
-    click_on "Save"
+    fill_in 'Name', with: 'Name 2'
+    fill_in 'Email', with: 'Email 2'
+    click_button 'Save'
 
-    expect(page).to have_content("Name 2")
-    expect(page).to_not have_content("Name 1")
+    expect(page).to have_content('Name 2')
+    expect(page).to_not have_content('Name 1')
   end
 
-  scenario "Delete an item", js: true do
-    User.create(name: "Name 1", email: "Email 1")
+  scenario 'Delete an item', js: true do
+    User.create(name: 'Name 1', email: 'Email 1')
 
     visit admin_users_path
     find('.destroy').click
-    within('.confirmation_box') { click_on "Yes" }
+    within('.confirmation_box') { click_button 'Yes' }
 
-    expect(page).to_not have_content("Name 1")
+    expect(page).to_not have_content('Name 1')
   end
 
-  scenario "Use a custom action", js: true do
-    User.create(name: "Name 1", email: "Email 1")
+  scenario 'Use a custom action', js: true do
+    User.create(name: 'Name 1', email: 'Email 1')
 
     visit admin_users_path
     find('.change_name').click
 
-    expect(page).to have_content("Changed Name")
+    expect(page).to have_content('Changed Name')
   end
 end

spec/features/view_items_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.feature 'View a list of items' do
@@ -6,39 +8,39 @@
   scenario 'The user navigate through users', js: true do
     visit root_path
 
-    #page_sizes => [3, 10]
-    expect(page).to have_content("Betty")
-    expect(page).to_not have_content("Edward")
+    # page_sizes => [3, 10]
+    expect(page).to have_content('Betty')
+    expect(page).to_not have_content('Edward')
 
-    within(".pagination") { click_on "2" }
+    within('.pagination') { click_link '2' }
 
-    expect(page).to have_content("Edward")
-    expect(page).to_not have_content("Betty")
+    expect(page).to have_content('Edward')
+    expect(page).to_not have_content('Betty')
   end
 
-  scenario "The user sort users", js: true do
+  scenario 'The user sort users', js: true do
     visit sortable_users_path
 
     find('.name a').click
-    expect(find(:xpath, "//table/tbody/tr[1]")).to have_content("Aaron")
-    expect(find(:xpath, "//table/tbody/tr[2]")).to have_content("Betty")
+    expect(find(:xpath, '//table/tbody/tr[1]')).to have_content('Aaron')
+    expect(find(:xpath, '//table/tbody/tr[2]')).to have_content('Betty')
 
     find('.name a').click
-    expect(find(:xpath, "//table/tbody/tr[1]")).to have_content("Sara")
-    expect(find(:xpath, "//table/tbody/tr[2]")).to have_content("Robin")
+    expect(find(:xpath, '//table/tbody/tr[1]')).to have_content('Sara')
+    expect(find(:xpath, '//table/tbody/tr[2]')).to have_content('Robin')
   end
 
-  scenario "The user search user", js: true do
+  scenario 'The user search user', js: true do
     visit admin_users_path
 
-    fill_in "filter", with: "ja"
+    fill_in 'filter', with: 'ja'
 
-    expect(page).to have_content("Jane")
-    expect(page).to_not have_content("Aaron")
+    expect(page).to have_content('Jane')
+    expect(page).to_not have_content('Aaron')
 
-    fill_in "filter", with: "ni"
+    fill_in 'filter', with: 'ni'
 
-    expect(page).to_not have_content("Nicholas")
-    expect(page).to_not have_content("Jane")
+    expect(page).to_not have_content('Nicholas')
+    expect(page).to_not have_content('Jane')
   end
 end