You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Its not safe to close acts channel, some goroutines may send there causing such crashes. Here I rewrote this logic, and it seems to work fine. Also, I added a feature of parsing json numbers as json.Number, #129.
Take a look at it please, and if everything is ok, I'll do a PR.
The text was updated successfully, but these errors were encountered:
This looks nice and I would like if this was merged. I'm no contributor of this however...
One thing though, NewWebsocketPeer(MSGPACK, fmt.Sprintf("ws://localhost:%d/", port), nil, nil, nil)
All these nil's starts to get a bit weird, wouldn't it be better if NewWebsocketPeer takes a "options" struct or something instead?
Its not safe to close
acts
channel, some goroutines may send there causing such crashes.Here I rewrote this logic, and it seems to work fine. Also, I added a feature of parsing json numbers as json.Number, #129.
Take a look at it please, and if everything is ok, I'll do a PR.
The text was updated successfully, but these errors were encountered: