Add Signature size for HMAC_SHA256 and HMAC_SHA384

Added new signature sizes for encryption types (19 and 20) which are common in modern KDC installations. Values are taken from rfc8009 https://datatracker.ietf.org/doc/html/rfc8009#section-7
jcmturner · May 6, 2023 · 855dbc7 · 855dbc7
1 parent f8771d3
commit 855dbc7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/pac/signature_data.go b/pac/signature_data.go
@@ -43,6 +43,10 @@ func (k *SignatureData) Unmarshal(b []byte) (rb []byte, err error) {
 		c = 12
 	case uint32(chksumtype.HMAC_SHA1_96_AES256):
 		c = 12
+	case uint32(chksumtype.HMAC_SHA256_128_AES128):
+		c = 16
+	case uint32(chksumtype.HMAC_SHA384_192_AES256):
+		c = 24
 	}
 	k.Signature, err = r.ReadBytes(c)
 	if err != nil {

diff --git a/v8/pac/signature_data.go b/v8/pac/signature_data.go
@@ -43,6 +43,10 @@ func (k *SignatureData) Unmarshal(b []byte) (rb []byte, err error) {
 		c = 12
 	case uint32(chksumtype.HMAC_SHA1_96_AES256):
 		c = 12
+	case uint32(chksumtype.HMAC_SHA256_128_AES128):
+		c = 16
+	case uint32(chksumtype.HMAC_SHA384_192_AES256):
+		c = 24
 	}
 	k.Signature, err = r.ReadBytes(c)
 	if err != nil {