Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: switch from compilation-start to compile #137

Open
Gastove opened this issue Aug 23, 2018 · 1 comment
Open

Proposal: switch from compilation-start to compile #137

Gastove opened this issue Aug 23, 2018 · 1 comment

Comments

@Gastove
Copy link

Gastove commented Aug 23, 2018

Right now, compiling an Elm file with elm make is eventually run with compilation-start. I'd like to suggest switching to using compile; it does for free most of what compilation-start needs done manually, and it has the added advantage that it remembers your last command for use with recompile. So for instance -- if you C-u C-c C-c to start a compilation with a specified output, you can then recompile to run the same compilation over as needed (an advantage not shared with compilation-start).

I'm happy to PR this change if it's welcome!

@purcell
Copy link
Collaborator

purcell commented Aug 26, 2018

Sounds reasonable at first glance, as long as elm-compilation-mode is still applied. My one concern is that recompile would not know to apply that mode, so the ANSI escape colourisation wouldn't work when recompiling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants