4903: tests refactoring BADGE #5023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kate-Semenova
force-pushed
the
4903_Tests_refactoring_BADGE_element
branch
from
1198840 to
4e60ac8
Compare
pnatashap
requested changes
Jul 24, 2023
...ght-angular-tests/src/test/java/io/github/epam/angular/tests/elements/common/BadgeTests.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Badge.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Badge.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Badge.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Badge.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/asserts/BadgeAssert.java
Outdated
Show resolved
Hide resolved
pnatashap
requested changes
Aug 11, 2023
| iconWithBadge.badge().is().displayed(); | ||
| iconWithBadge.badge().has().text("15"); | ||
| iconWithBadge.has().color("Red"); | ||
| iconWithBadge.is().displayed() |
There was a problem hiding this comment.
if this is icon badge, we should have a validation for icon, if not, there is no difference with buttonWithBadge and should be removed
...ght-angular-tests/src/test/java/io/github/epam/angular/tests/elements/common/BadgeTests.java
Outdated
Show resolved
Hide resolved
...ght-angular-tests/src/test/java/io/github/epam/angular/tests/elements/common/BadgeTests.java
Outdated
Show resolved
Hide resolved
...ght-angular-tests/src/test/java/io/github/epam/angular/tests/elements/common/BadgeTests.java
Outdated
Show resolved
Hide resolved
...ght-angular-tests/src/test/java/io/github/epam/angular/tests/elements/common/BadgeTests.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Badge.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Badge.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Badge.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Badge.java
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/enums/BadgeSize.java
Outdated
Show resolved
Hide resolved
MayaElf
requested changes
Aug 23, 2023
...ght-angular-tests/src/test/java/io/github/epam/angular/tests/elements/common/BadgeTests.java
Outdated
Show resolved
Hide resolved
pnatashap
requested changes
Aug 24, 2023
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/common/Badge.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/enums/BadgePosition.java
Outdated
Show resolved
Hide resolved
| } | ||
| return BadgePosition.UNKNOWN; |
There was a problem hiding this comment.
By default position is after, so only if we have mat-badge-before it will be BEFORE, in all other variants AFTER
Kate-Semenova
force-pushed
the
4903_Tests_refactoring_BADGE_element
branch
from
82593bb to
6802696
Compare
Kate-Semenova
commented
Aug 24, 2023
Kate-Semenova
force-pushed
the
4903_Tests_refactoring_BADGE_element
branch
from
6802696 to
009abaa
Compare
Kate-Semenova
force-pushed
the
4903_Tests_refactoring_BADGE_element
branch
from
009abaa to
7ca902f
Compare
MayaElf
approved these changes
Aug 29, 2023
pnatashap
requested changes
Sep 8, 2023
| AFTER, | ||
| BEFORE, | ||
| UNKNOWN | ||
|
|
| } | ||
| return BadgePosition.UNKNOWN; |
pnatashap
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.