Skip to content

Commit

Permalink
Merge pull request #1696 from jdi-testing/issue_1541-wrong-text-in-on…
Browse files Browse the repository at this point in the history
…boarding-step

Issue 1541: fix wrong text in onboarding step (Vuetify)
  • Loading branch information
KateDronova authored Apr 1, 2024
2 parents bc967b2 + 4e0d38a commit 86531eb
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 4 deletions.
2 changes: 1 addition & 1 deletion manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "JDN — Page Object Generator",
"description": "JDN – helps Test Automation Engineer to create Page Objects in the test automation framework and speed up test development",
"devtools_page": "index.html",
"version": "3.15.16",
"version": "3.15.17",
"icons": {
"128": "icon128.png"
},
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "jdn-ai-chrome-extension",
"version": "3.15.16",
"version": "3.15.17",
"description": "jdn-ai chrome extension",
"scripts": {
"start": "webpack --watch --env devenv",
Expand Down
4 changes: 4 additions & 0 deletions src/features/onboarding/OnboardingProvider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ const generateSteps = (
stepData.prevButtonProps = {
style: { display: isCustomLocatorFlow ? 'none' : 'inline-block' },
};
stepData.title = isCustomLocatorFlow ? 'Add the locator to Page Object.' : 'Add the locator to the Page Object';
stepData.description = isCustomLocatorFlow
? 'Custom locators are added as selected by default.'
: 'Select the needed locators (or choose all of them) to create the final Page object. Note that only selected locators will be added to the final Locators List.';
}

if (stepData.order === OnboardingStep.ContextMenu) {
Expand Down
3 changes: 2 additions & 1 deletion src/features/onboarding/constants.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@ export const onboardingSteps: IOnboardingSteps = {
AddToPO: {
order: OnboardingStep.AddToPO,
title: 'Add the locator to the Page Object',
description: 'Custom locators are added as selected by default.',
description:
'Select the needed locators (or choose all of them) to create the final Page object. Note that only selected locators will be added to the final Locators List.',
target: undefined,
prevButtonProps: {
children: 'Back',
Expand Down

0 comments on commit 86531eb

Please sign in to comment.