Skip to content

Commit

Permalink
Use explicit github runner versions during testing
Browse files Browse the repository at this point in the history
To avoid accidents, we mention the exact
  • Loading branch information
ssbarnea committed Dec 30, 2024
1 parent 249c01b commit 7a1fd22
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/check-dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ concurrency:
jobs:
check-dist:
name: Check dist/
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ concurrency:
jobs:
test-typescript:
name: TypeScript Tests
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ concurrency:
jobs:
analyze:
name: Analyze
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

permissions:
actions: read
Expand Down
14 changes: 9 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ concurrency:

jobs:
build: # make sure build/ci work properly
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- run: |
Expand All @@ -25,9 +25,13 @@ jobs:
fail-fast: false
matrix:
os:
- macos-latest
- ubuntu-latest
- windows-latest
# Do not use latest as we have zero control regarding when it does
# change. OK to add multiple versions of the same OS when needed,
# especially as new ones are added rarely.
# https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for--private-repositories
- macos-15
- ubuntu-24.04
- windows-2022
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
Expand All @@ -46,7 +50,7 @@ jobs:
- run: . scripts/test.sh
shell: bash
specific_version:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- name: Setup mise
Expand Down

0 comments on commit 7a1fd22

Please sign in to comment.