ls-remote: fetch versions in parallel (#1119)

* ls-remote: fetch versions in parallel * lint dockerfile
jdx · Dec 8, 2023 · ac8b490 · ac8b490
1 parent e1d2ff9
commit ac8b490
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/packaging/rtx/Dockerfile b/packaging/rtx/Dockerfile
@@ -1,5 +1,6 @@
 FROM ubuntu:22.04
 LABEL maintainer="jdx"
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
 
 ENV RTX_DATA_DIR="/rtx"
 ENV RTX_CONFIG_DIR="/rtx"

diff --git a/src/cli/ls_remote.rs b/src/cli/ls_remote.rs
@@ -1,6 +1,7 @@
 use std::sync::Arc;
 
 use color_eyre::eyre::Result;
+use rayon::prelude::*;
 
 use crate::cli::args::tool::ToolArg;
 use crate::cli::args::tool::ToolArgParser;
@@ -65,10 +66,18 @@ impl LsRemote {
     }
 
     fn run_all(self, config: Config, out: &mut Output) -> Result<()> {
-        for plugin in config.plugins.values() {
-            let versions = plugin.list_remote_versions(&config.settings)?;
-            for version in versions {
-                rtxprintln!(out, "{}@{}", plugin.name(), version);
+        let versions = config
+            .plugins
+            .values()
+            .par_bridge()
+            .map(|p| {
+                let versions = p.list_remote_versions(&config.settings)?;
+                Ok((p, versions))
+            })
+            .collect::<Result<Vec<_>>>()?;
+        for (plugin, versions) in versions {
+            for v in versions {
+                rtxprintln!(out, "{}@{v}", plugin);
             }
         }
         Ok(())