-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Danger-swift requers libDanger to be in system directories #3424
Comments
Steps to reproduce: ❯ git clone https://github.com/msnazarow/DangerMiseCheck
❯ cd DangerMiseCheck
❯ git checkout master
❯ git checkout danger-check
❯ mise use danger-swift npm:danger
❯ danger-swift local I think it's unlikely that mise will copy anything into system prefix directories for you. But the fact its looking in .build/release is a good sign. I wonder if we can copy that into the install directory. I'm not sure what that path is relative to. The spm backend is still experimental so this sort of problem is expected. Also @msnazarow your screenshot upload failed, you might want to try again. |
As i did here you can path PREFIX to Makefile like I added ~/.local/share/mise/installs/danger-swift/(version)/lib this path for search in danger-swift So first of all, there should be libs somewhere, and that directory should be hardcoded in danger sources |
Screenshot contained lib directory with libDanger and other support swiftmodule files |
I see @msnazarow has added the lib path |
@jdx mise run As i mensioned before, you should reference Makefile and install script |
that would only be a solution for this one tool, the backend should support any spm package |
I think you can just call swift build without --product specification |
Describe the bug
when danger-swift is installed via Makefile(also via brew, cause brew runs make install PREFIX=/opt/homebrew/Cellar/danger-swift/3.20.2) it copies libDanger into prefix directories(or system if prefix isn't used)
And when it is installed via mise, it copies only danger-swift, and it's not enough
To Reproduce
Expected behavior
Actual behavior
mise doctor
outputAdditional context
Add any other context about the problem here. Consider running mise with
--debug
or--trace
for extra debug info.The text was updated successfully, but these errors were encountered: